-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operator interface for Probe pkg #4849
Open
sukkyun2
wants to merge
9
commits into
litmuschaos:master
Choose a base branch
from
sukkyun2:refactor/add-operator-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add operator interface for Probe pkg #4849
sukkyun2
wants to merge
9
commits into
litmuschaos:master
from
sukkyun2:refactor/add-operator-interface
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add probeOperator to probe pkg - Add probeOperator to handler that uses probeUtils - Add probe operator as parameter to functions that use probe operations in probeUtils Signed-off-by: sukkyun2 <[email protected]>
Signed-off-by: sukkyun2 <[email protected]>
- Apply goimports Signed-off-by: sukkyun2 <[email protected]>
sukkyun2
force-pushed
the
refactor/add-operator-interface
branch
from
August 28, 2024 09:32
579cec1
to
5186dbf
Compare
Saranya-jena
approved these changes
Sep 6, 2024
namkyu1999
approved these changes
Sep 6, 2024
can you check a build-pipeline? @sukkyun2 |
namkyu1999
approved these changes
Sep 6, 2024
S-ayanide
requested changes
Sep 9, 2024
- Updated handler to call GenerateExperimentManifestWithProbes, GenerateCronExperimentManifestWithProbes via ProbeService Signed-off-by: sukkyun2 <[email protected]>
- add mock probeService generated by mockery Signed-off-by: sukkyun2 <[email protected]>
Signed-off-by: sukkyun2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds operator interface to probe pkg
#4836, I tried to add fuzz test for probe handler.
However, the current architecture made it impossible to mock probe operations, so I added probe operator interface.
This picture is about probe pkg.
References
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
I need feedback on the approach of passing
probeOperator
as a parameter to functions.For example, the function
GenerateExperimentManifestWithProbes
in chaoscenter/graphql/server/pkg/probe/utils/utils.go directly accesses probe operation. I have added theprobeOperator
dependency to the handler that usesGenerateExperimentManifestWithProbes
and updated the function calls to passprobeOperator
as a parameter.